> On March 11, 2016, 4 a.m., Joris Van Remoortere wrote:
> > 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake, lines 70-71
> > <https://reviews.apache.org/r/43708/diff/1/?file=1253549#file1253549line70>
> >
> >     What does setting it twice do?

It appends `${ZLIB_ROOT}-build` to a list with `${ZLIB_ROOT}` in it. This is 
required becaues `zconfig.h` is in the `-build` folder.

We can make it a one-liner though: ` set(ZLIB_INCLUDE_DIR ${ZLIB_ROOT} 
${ZLIB_ROOT}-build)`.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43708/#review123086
-----------------------------------------------------------


On Feb. 18, 2016, 5:25 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43708/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2016, 5:25 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-4704
>     https://issues.apache.org/jira/browse/MESOS-4704
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This review was originally at #40568, put up by Dario Bazan. Dario went
> on paternity leave, so I've dusted it off, rebased it against the state
> of the art, and gotten it ready for submission. It remains mostly
> unchanged, with only minor alterations from the original.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt 
> 9b61376ea6aad304607c20c9823d9ef19013eca0 
>   3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
> d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673 
>   3rdparty/libprocess/cmake/ProcessConfigure.cmake 
> 2a37fdb6501aaf7baac2ada0a714bbe67e7c5aca 
> 
> Diff: https://reviews.apache.org/r/43708/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Reply via email to