> On March 10, 2016, 10:06 p.m., Vinod Kone wrote:
> > src/Makefile.am, line 158
> > <https://reviews.apache.org/r/44320/diff/8/?file=1294373#file1294373line158>
> >
> >     any reason why this should be exposed in the include directory?
> 
> Alexander Rojas wrote:
>     Main reason is because of this `static Try<Authorizer*> 
> mesos::Authorizer::create(const ACLs& acls);` which is already part of the 
> public API, although it can be forward declared there (It is, actually).
>     
>     But it is mentioned in the public API so I thought it should go there 
> anyway.

Moreover, in this patch we have not yet change the signature of the 
`Authorizer`, so every method requires as a parameter one of the `ACL` sub 
messages (whichcannot be forward declared because `ACL` is not a namespace).

This however can be done in a later patch.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44320/#review122988
-----------------------------------------------------------


On March 10, 2016, 3:09 p.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44320/
> -----------------------------------------------------------
> 
> (Updated March 10, 2016, 3:09 p.m.)
> 
> 
> Review request for mesos, Adam B, Joerg Schad, and Vinod Kone.
> 
> 
> Bugs: MESOS-2950
>     https://issues.apache.org/jira/browse/MESOS-2950
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is the first step towards separating the language used to define
> the ACLs from the mechanism to query them.
> 
> 
> Diffs
> -----
> 
>   include/mesos/authorizer/acls.hpp PRE-CREATION 
>   include/mesos/authorizer/authorizer.hpp 
> 705482656788ac12e9d21e355b71fd2ede2be558 
>   include/mesos/authorizer/authorizer.proto  
>   src/CMakeLists.txt e9f7c3a447aad79ab19d53879888a413a587408f 
>   src/Makefile.am b24f0f58fa188c16770fe6a3c23ec06262cb0955 
>   src/authorizer/acls.cpp PRE-CREATION 
>   src/authorizer/authorizer.cpp 54278b022118c40d3b976794fd472ce8d8b6a5e2 
>   src/common/parse.hpp 78c7cf12ca6a475305254177db6b6b2319a1f72f 
>   src/examples/persistent_volume_framework.cpp 
> 4218b1563e10aaefe9abcdc20c90c13651959790 
>   src/examples/test_authorizer_module.cpp 
> 95d77fbff0cdfdb360a8597fbba28404b59d0042 
>   src/master/flags.hpp 6f53099eab9b0e5917e508bef24b2c85302b33e2 
>   src/master/quota_handler.cpp a41c91f10bc0eedc754425b4de1b3e184c4ffb08 
> 
> Diff: https://reviews.apache.org/r/44320/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Reply via email to