-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44555/#review123154
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/network/cni.cpp (line 133)
<https://reviews.apache.org/r/44555/#comment185330>

    kill this. `pluginPath` already has the location information?



src/slave/containerizer/mesos/isolators/network/cni.cpp (line 146)
<https://reviews.apache.org/r/44555/#comment185336>

    Missing `'` after `path`



src/slave/containerizer/mesos/isolators/network/cni.cpp (line 157)
<https://reviews.apache.org/r/44555/#comment185337>

    kill this.



src/slave/containerizer/mesos/isolators/network/cni.cpp (line 170)
<https://reviews.apache.org/r/44555/#comment185338>

    Missing `'` after `path`


- Avinash sridharan


On March 9, 2016, 6:01 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44555/
> -----------------------------------------------------------
> 
> (Updated March 9, 2016, 6:01 a.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-4759
>     https://issues.apache.org/jira/browse/MESOS-4759
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented the framework and create() method of "network/cni" isolator.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 8f57a5701073bf1eaaa223383e928cf5db8f8ae4 
>   src/Makefile.am a41e95ddeb838fdebf4ced953c4a29181916e261 
>   src/slave/containerizer/mesos/isolators/network/cni.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/network/cni.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44555/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Reply via email to