----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44621/#review123185 -----------------------------------------------------------
Fix it, then Ship it! src/tests/master_maintenance_tests.cpp (lines 1770 - 1772) <https://reviews.apache.org/r/44621/#comment185376> One line? src/tests/master_maintenance_tests.cpp (lines 1770 - 1772) <https://reviews.apache.org/r/44621/#comment185380> One line? src/tests/master_tests.cpp (line 4195) <https://reviews.apache.org/r/44621/#comment185388> Looks like there are no POST requests here? src/tests/master_tests.cpp (lines 4197 - 4199) <https://reviews.apache.org/r/44621/#comment185385> s/observe in the/observe endpoints in the/ Or, you could just say "we have similar checks for other endpoints in their respective..." ? src/tests/master_tests.cpp (lines 4212 - 4214) <https://reviews.apache.org/r/44621/#comment185377> One line? Here and below in this file src/tests/role_tests.cpp (line 657) <https://reviews.apache.org/r/44621/#comment185390> Since this file contains other tests which have nothing to do with HTTP endpoints, perhaps this name should be a bit more descriptive? Something like `RolesEndpointBadAuthentication`? - Greg Mann On March 10, 2016, 2:41 p.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44621/ > ----------------------------------------------------------- > > (Updated March 10, 2016, 2:41 p.m.) > > > Review request for mesos, Adam B and Alexander Rojas. > > > Bugs: MESOS-4844 > https://issues.apache.org/jira/browse/MESOS-4844 > > > Repository: mesos > > > Description > ------- > > With enabling http authentication for http endpoints we should also add tests > to check > that http request to those endpoints return "401 Unauthorized" if queried > without or with > bad credentials. > > > Diffs > ----- > > src/tests/master_maintenance_tests.cpp > 3faa8136cf57276295553910319480028f433e4c > src/tests/master_tests.cpp 2f4d820e223a48700ce1ac3a91b7256cc836c268 > src/tests/repair_tests.cpp bb104562659e135492f9857e5b452c8a0a9e97da > src/tests/role_tests.cpp fc3a72894631279460ee7971a4627d73c3d8c351 > > Diff: https://reviews.apache.org/r/44621/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joerg Schad > >
