----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44191/#review123255 -----------------------------------------------------------
Fix it, then Ship it! We may want to update the description to say that the constexpr change is to bring it in-line with the latest style guidelines for the project. Initially when I read performance I thought we were trying to optimize something without a basis. :) src/master/constants.hpp (lines 120 - 121) <https://reviews.apache.org/r/44191/#comment185463> Any reason this Duration constant wasn't changed to constexpr? - Ben Mahler On March 11, 2016, 6:31 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44191/ > ----------------------------------------------------------- > > (Updated March 11, 2016, 6:31 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-4790 > https://issues.apache.org/jira/browse/MESOS-4790 > > > Repository: mesos > > > Description > ------- > > We were only using external linkage to workaround bugs in ancient > (4.1.x) of GCC. We can also mark most of these constants `constexpr`, > which should be both slightly more efficient (in theory) and > safer (see MESOS-1023). > > > Diffs > ----- > > src/CMakeLists.txt e9f7c3a447aad79ab19d53879888a413a587408f > src/Makefile.am b24f0f58fa188c16770fe6a3c23ec06262cb0955 > src/master/constants.hpp 2c3299bc1aaa0888f7e47a71965c56ada8ecc21f > src/master/constants.cpp e316f9772d880b694faeee6d001dc56bc088c118 > > Diff: https://reviews.apache.org/r/44191/diff/ > > > Testing > ------- > > make check > > Note that I left a few string constants as `const std::string`; you might > arguably want them to be `constexpr char[]` (per Google Style Guide). > > > Thanks, > > Neil Conway > >
