-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42590/#review123267
-----------------------------------------------------------




include/mesos/resources.hpp (line 228)
<https://reviews.apache.org/r/42590/#comment185472>

    I think we need to update document about the `Option<std::string> role`


- Klaus Ma


On March 12, 2016, 10:47 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42590/
> -----------------------------------------------------------
> 
> (Updated March 12, 2016, 10:47 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van 
> Remoortere, Joseph Wu, and Klaus Ma.
> 
> 
> Bugs: MESOS-4447
>     https://issues.apache.org/jira/browse/MESOS-4447
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Renamed reserved() to reservations().
> 
> 
> Diffs
> -----
> 
>   include/mesos/resources.hpp 388c4f383b77be490cb2debb64a734c6d6e4a176 
>   include/mesos/v1/resources.hpp 64ad8bf08230aeaa173325364c91b765f091210e 
>   src/common/resources.cpp cf0707209143084d86aff5e4427846f461479c54 
>   src/master/http.cpp 893e0651b89de4df1813f8f4f365eab80a7b3bc2 
>   src/tests/resources_tests.cpp 5357275833383bbff055689c8c1d0fa59791f2d0 
>   src/v1/resources.cpp 296c4c2392384a2fcc4f2c1843980ff97e71114d 
> 
> Diff: https://reviews.apache.org/r/42590/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> ./bin/mesos-tests.sh  --gtest_filter="ResourcesTest.*"
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Reply via email to