----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44766/#review123377 -----------------------------------------------------------
3rdparty/libprocess/include/process/help.hpp (line 44) <https://reviews.apache.org/r/44766/#comment185621> Maybe this comment could recommend that this say "authenticated" or "unauthenticated", or "required" or whatever. 3rdparty/libprocess/src/help.cpp (line 43) <https://reviews.apache.org/r/44766/#comment185622> What if this was a bool instead of a string? How many values do you expect? - Adam B On March 13, 2016, 3:31 p.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44766/ > ----------------------------------------------------------- > > (Updated March 13, 2016, 3:31 p.m.) > > > Review request for mesos, Adam B and Greg Mann. > > > Repository: mesos > > > Description > ------- > > Enabled endpoint HELP string to display information about authentication > requirements. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/help.hpp > 783304e2fc78db70f1a5fccbf5e96fcc76a88fd8 > 3rdparty/libprocess/src/help.cpp 5f368801affecacb0d1daaeb6ccf5895ccb231d2 > 3rdparty/libprocess/src/logging.cpp > 015a43db77fd7015aeee0c45fa10c292f3e9cf58 > > Diff: https://reviews.apache.org/r/44766/diff/ > > > Testing > ------- > > Viewed master endpoint help in browser. > > > Thanks, > > Joerg Schad > >
