----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/ -----------------------------------------------------------
(Updated March 14, 2016, 10:04 a.m.) Review request for mesos, Adam B, Neil Conway, and Qian Zhang. Changes ------- Addressed comments of Adam. Bugs: MESOS-4200 https://issues.apache.org/jira/browse/MESOS-4200 Repository: mesos Description ------- Add tests for /weights endpoint. Diffs (updated) ----- src/Makefile.am f2a592dba3e963c99c48c4b9045b4a04d173cb22 src/tests/dynamic_weights_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/41790/diff/ Testing ------- Make and Make check successfully! $ ./src/mesos-tests --gtest_filter=DynamicWeightsTest.* [==========] Running 11 tests from 1 test case. [----------] Global test environment set-up. [----------] 11 tests from DynamicWeightsTest [ RUN ] DynamicWeightsTest.PutInvalidRequest [ OK ] DynamicWeightsTest.PutInvalidRequest (87 ms) [ RUN ] DynamicWeightsTest.ZeroWeight [ OK ] DynamicWeightsTest.ZeroWeight (44 ms) [ RUN ] DynamicWeightsTest.NegativeWeight [ OK ] DynamicWeightsTest.NegativeWeight (42 ms) [ RUN ] DynamicWeightsTest.NonNumericWeight [ OK ] DynamicWeightsTest.NonNumericWeight (37 ms) [ RUN ] DynamicWeightsTest.MissingRole [ OK ] DynamicWeightsTest.MissingRole (42 ms) [ RUN ] DynamicWeightsTest.UnknownRole [ OK ] DynamicWeightsTest.UnknownRole (38 ms) [ RUN ] DynamicWeightsTest.UpdateWeightsWithExplictRoles [ OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (38 ms) [ RUN ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest [ OK ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest (35 ms) [ RUN ] DynamicWeightsTest.AuthorizedWeightUpdateRequest [ OK ] DynamicWeightsTest.AuthorizedWeightUpdateRequest (45 ms) [ RUN ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal [ OK ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal (38 ms) [ RUN ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest [ OK ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest (35 ms) [----------] 11 tests from DynamicWeightsTest (482 ms total) [----------] Global test environment tear-down [==========] 11 tests from 1 test case ran. (490 ms total) [ PASSED ] 11 tests. Thanks, Yongqiao Wang