-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44733/#review123423
-----------------------------------------------------------




src/tests/http_fault_tolerance_tests.cpp (lines 86 - 89)
<https://reviews.apache.org/r/44733/#comment185682>

    I don't think we need to test for both PROTOBUF and JSON for these tests. 
Lets just do PROTOBUF.



src/tests/http_fault_tolerance_tests.cpp (lines 105 - 106)
<https://reviews.apache.org/r/44733/#comment185685>

    pull this down to clock::advance().



src/tests/http_fault_tolerance_tests.cpp (lines 215 - 216)
<https://reviews.apache.org/r/44733/#comment185684>

    pull this down to where we send teardown call.



src/tests/http_fault_tolerance_tests.cpp (line 483)
<https://reviews.apache.org/r/44733/#comment185686>

    s/is/to be/



src/tests/http_fault_tolerance_tests.cpp (line 565)
<https://reviews.apache.org/r/44733/#comment185687>

    s/executorLib/executorLibrary/
    
    also, it's a bit weird that scheduler library is called 'mesos' whereas 
executor library is called 'executorLib'. can we make the names more symmetric? 
e.g., 'schedulerLibrary' and 'executorLibrary'?
    
    here and everywhere else.



src/tests/http_fault_tolerance_tests.cpp (line 569)
<https://reviews.apache.org/r/44733/#comment185688>

    s/launched/launch/



src/tests/http_fault_tolerance_tests.cpp (line 739)
<https://reviews.apache.org/r/44733/#comment185689>

    s/launched/launch/



src/tests/http_fault_tolerance_tests.cpp (line 847)
<https://reviews.apache.org/r/44733/#comment185691>

    not sure why this test is part of fault tolerance tests?


- Vinod Kone


On March 11, 2016, 10:16 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44733/
> -----------------------------------------------------------
> 
> (Updated March 11, 2016, 10:16 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4629
>     https://issues.apache.org/jira/browse/MESOS-4629
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Similar to already existing tests in `fault_tolerance_tests.cpp`,
> this change adds fault tolerance tests for HTTP schedulers/executors.
> Some tests have been omitted since they were no longer valid now due
> to the persistent streaming connection between the master and the
> scheduler in the new API.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 8abef3bd3237a6e456faa7884637207dc4d63282 
>   src/tests/http_fault_tolerance_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44733/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Reply via email to