> On March 11, 2016, 6:45 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni.cpp, line 358 > > <https://reviews.apache.org/r/44706/diff/1/?file=1295806#file1295806line358> > > > > If we block here, it will lock the isolator, and prevent the > > `MesosContainerizer` from launching any more containers? > > Qian Zhang wrote: > I do not think it will prevent `MesosContainerizer` from launching any > more containers. Please take a look at: > https://github.com/apache/mesos/blob/0.27.2/src/slave/containerizer/mesos/containerizer.cpp#L945:L1034, > the whole code to call launcher to fork executor process and call isolator's > `isolate()` are already in a `defer()` as a lambda, and it is also a very big > lambda.
Hi Qian, Didn't understand your comment. Are you implying calling `await` on the `Future` won't block? - Avinash ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44706/#review123181 ----------------------------------------------------------- On March 11, 2016, 2:10 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44706/ > ----------------------------------------------------------- > > (Updated March 11, 2016, 2:10 p.m.) > > > Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu. > > > Bugs: MESOS-4759 > https://issues.apache.org/jira/browse/MESOS-4759 > > > Repository: mesos > > > Description > ------- > > Implemented isolate() method of "network/cni" isolator. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/cni.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/network/cni.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/44706/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Qian Zhang > >
