-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44635/#review123584
-----------------------------------------------------------


Fix it, then Ship it!




Just a minor tweak that I'll apply.


src/exec/exec.cpp (lines 712 - 713)
<https://reviews.apache.org/r/44635/#comment185810>

    We tend to put the space on the next line, and I think having the "of" on 
the next line is clearer here, so:
    
    ```
              EXIT(EXIT_FAILURE)
                << "Failed to parse value '" << value.get() << "'"
                << " of 'MESOS_RECOVERY_TIMEOUT': " << parse.error();
    ```


- Ben Mahler


On March 14, 2016, 5:45 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44635/
> -----------------------------------------------------------
> 
> (Updated March 14, 2016, 5:45 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/exec/exec.cpp dec7e8814e7151718d1c89381458753f2e22739e 
> 
> Diff: https://reviews.apache.org/r/44635/diff/
> 
> 
> Testing
> -------
> 
> The complete chain was tested. See https://reviews.apache.org/r/44662/.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Reply via email to