-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44836/#review123607
-----------------------------------------------------------



Thank you for your patch. Could you update the `Bugs` field to `MESOS-4930`? By 
the way, I think you need find a shepherd for this ticket. Could you follow 
this guide 
https://github.com/apache/mesos/blob/master/docs/submitting-a-patch.md to find 
the committer which could help you review this more detail and help you submit?


src/examples/long_lived_framework.cpp (line 92)
<https://reviews.apache.org/r/44836/#comment185843>

    We have a function in `<stout/format.hpp>`. I think you could use it like 
this directly.
    
    ```
    strings::format("%06d", xxx)
    ```


- haosdent huang


On March 15, 2016, 6:54 a.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44836/
> -----------------------------------------------------------
> 
> (Updated March 15, 2016, 6:54 a.m.)
> 
> 
> Review request for mesos and haosdent huang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Current WebUI sorts taskId lexically, which results in non-intuitive ordering.
> This patch updates long_lived_framework to use `000001`, `000002` instead.
> 
> Signed-off-by: Zhou Xing <xingz...@cn.ibm.com>
> 
> 
> Diffs
> -----
> 
>   src/examples/long_lived_framework.cpp 
> 0000289a0b9dd3d1ce30f20dd9bb381126bff30c 
> 
> Diff: https://reviews.apache.org/r/44836/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> In addition, `long_lived_framework` is ran and we confirm correct sorting of 
> `TaskID` in WebUI
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Reply via email to