> On March 15, 2016, 3:06 a.m., Ben Mahler wrote:
> > Thanks, also two thoughts for later:
> > 
> > (1) I assume you've also updated this in a subsequent patch for when 
> > ExecutorInfo includes a grace period.
> > 
> > (2) I would also like to clarify that this is the _most_ amount of time 
> > they will get. They must not assume they will be alloted this full amount 
> > of time. I assume that you'll borrow the comments I had written for the 
> > 'shutdown_grace_period' in the ExecutorInfo changes?

Good points, Ben! I'll revisit the comment today.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44631/#review123581
-----------------------------------------------------------


On March 14, 2016, 5:45 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44631/
> -----------------------------------------------------------
> 
> (Updated March 14, 2016, 5:45 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   include/mesos/executor/executor.proto 
> a67dbad458e24b22875cf15b73b64c14a084b1ea 
>   include/mesos/v1/executor/executor.proto 
> c4ad0b4ac6a4e8def013b276877a9c0a5264d4e9 
> 
> Diff: https://reviews.apache.org/r/44631/diff/
> 
> 
> Testing
> -------
> 
> The complete chain was tested. See https://reviews.apache.org/r/44662/.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Reply via email to