-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44755/#review123688
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/containerizer/provisioner_appc_tests.cpp (lines 587 - 610)
<https://reviews.apache.org/r/44755/#comment185918>

    Can you move this function to the top of this file and make it 'static'?



src/tests/containerizer/provisioner_appc_tests.cpp (line 588)
<https://reviews.apache.org/r/44755/#comment185919>

    s/imageName/name/


- Jie Yu


On March 12, 2016, 5:11 p.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44755/
> -----------------------------------------------------------
> 
> (Updated March 12, 2016, 5:11 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added helper function to get an Appc image protobuf object with given
> parameters.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/provisioner_appc_tests.cpp 
> 069af8a0b5e031d9032fd13154cee250f279b404 
> 
> Diff: https://reviews.apache.org/r/44755/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Reply via email to