-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44654/#review123713
-----------------------------------------------------------



Looks great! Main thing is documenting why we don't assume the environment 
variable is present, and which version of the agent sets it.


src/exec/exec.cpp (line 110)
<https://reviews.apache.org/r/44654/#comment185957>

    If you'd like to add the `private` qualifier, why isn't `kill` left as 
protected?



src/exec/exec.cpp (line 707)
<https://reviews.apache.org/r/44654/#comment185956>

    A comment about why we don't require it to be set like the others above 
(backwards-compatibility) would be helpful for the reader here. Also would be 
good to mention that agents that are 0.29.0 (or did those patches land in 
0.28.0?) and above set this, so that we don't have to do a deeper investigation 
later if we want to figure out which agent version sets this.


- Ben Mahler


On March 15, 2016, 2:15 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44654/
> -----------------------------------------------------------
> 
> (Updated March 15, 2016, 2:15 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4911
>     https://issues.apache.org/jira/browse/MESOS-4911
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Executor shutdown grace period, which configured on the agent, is
> propagated to executors via the `MESOS_EXECUTOR_SHUTDOWN_GRACE_PERIOD`
> environment variable. The executor library uses this timeout to delay
> the hard shutdown of the related executor.
> 
> 
> Diffs
> -----
> 
>   src/exec/exec.cpp 741786132f3a8cc43f5b9ced262429038832a946 
> 
> Diff: https://reviews.apache.org/r/44654/diff/
> 
> 
> Testing
> -------
> 
> The complete chain was tested. See https://reviews.apache.org/r/44662/.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Reply via email to