> On 三月 15, 2016, 1:28 a.m., Guangya Liu wrote: > > src/tests/containerizer/runtime_isolator_tests.cpp, lines 96-98 > > <https://reviews.apache.org/r/44753/diff/1/?file=1296704#file1296704line96> > > > > The comments should also be updated? Also should mention that do not > > want use up disk due to work dir may be copied to rootfs? > > > > Ditto for other `flags.docker_store_dir` > > Jie Yu wrote: > I think the comments here still apply, right?
Do we need to mention that this can also help not use up disk? - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44753/#review123561 ----------------------------------------------------------- On 三月 15, 2016, 12:22 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44753/ > ----------------------------------------------------------- > > (Updated 三月 15, 2016, 12:22 a.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-4942 > https://issues.apache.org/jira/browse/MESOS-4942 > > > Repository: mesos > > > Description > ------- > > Fixed runtime isolator tests out of disk issue. > > > Diffs > ----- > > src/tests/containerizer/provisioner_docker_tests.cpp > 9fd5ea9e465f21624d3cdc0125a702528fe7548b > src/tests/containerizer/runtime_isolator_tests.cpp > d8a000413fb30d7daaa77827287a2395d81b8b04 > > Diff: https://reviews.apache.org/r/44753/diff/ > > > Testing > ------- > > make check > > sudo ./bin/mesos-test.sh > > > Thanks, > > Gilbert Song > >
