-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45000/#review124316
-----------------------------------------------------------




src/master/http.cpp (line 958)
<https://reviews.apache.org/r/45000/#comment186790>

    Looks like we specifically removed the scheme in 
https://reviews.apache.org/r/36018. @joris do you have context for why this was 
done?
    
    From the RFC linked in the comment (which is really useful, lets not kil 
that comment :)) scheme doesn't seem to be mandatory. We can add path from 
request but AFAICT the spec doesn't mandate it. cc @benwhitehead.


- Vinod Kone


On March 18, 2016, 12:04 a.m., Ashwin Murthy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45000/
> -----------------------------------------------------------
> 
> (Updated March 18, 2016, 12:04 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> MESOS-3902: Fix in location header during redirect from non-leader. The fix 
> is to add the scheme and path to the URL in the location header. Previously, 
> we did not have the scheme and path. We need to update the mesos http API 
> documentation section on master redirect to reflect this change.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp b47ab7cc86c0a56a81815a98bd63f37a1175ba7f 
> 
> Diff: https://reviews.apache.org/r/45000/diff/
> 
> 
> Testing
> -------
> 
> Was trying to write unit test in scheduler http api test but it turns out 
> multi master tests cannot be written at this point. Need to manually verify 
> this by setting up multiple masters with ZK.
> 
> 
> Thanks,
> 
> Ashwin Murthy
> 
>

Reply via email to