> On March 15, 2016, 8:11 p.m., Ben Mahler wrote: > > include/mesos/v1/executor/executor.proto, lines 53-55 > > <https://reviews.apache.org/r/44655/diff/4/?file=1299802#file1299802line53> > > > > Now that the period within the Shutdown message was removed, we should > > probably have a TODO following this note for adding the period into the > > Shutdown message so that the agent can communicate when a shorter period > > has been alloted.
I will add this TODO as food for thought, but I'm not sure we should introduce one, because even if we communicate the "actual" period, a failure may occur which will render this "actual" period incorrect. > On March 15, 2016, 8:11 p.m., Ben Mahler wrote: > > src/exec/exec.cpp, lines 715-716 > > <https://reviews.apache.org/r/44655/diff/4/?file=1299804#file1299804line715> > > > > Can you confirm the environment variable setting didn't make it in > > 0.28.0? Good catch, Ben, that change made it to 0.28 indeed. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44655/#review123731 ----------------------------------------------------------- On March 15, 2016, 3:49 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44655/ > ----------------------------------------------------------- > > (Updated March 15, 2016, 3:49 p.m.) > > > Review request for mesos, Ben Mahler and Gilbert Song. > > > Bugs: MESOS-4949 > https://issues.apache.org/jira/browse/MESOS-4949 > > > Repository: mesos > > > Description > ------- > > If `ExecutorInfo.shutdown_grace_period` is set, the executor > driver uses it, otherwise it falls back to the environment > variable `MESOS_EXECUTOR_SHUTDOWN_GRACE_PERIOD`. > > > Diffs > ----- > > docs/configuration.md 739d4ff9aeeb1ba70ce11033168d63d37b6ef56b > include/mesos/executor/executor.proto > ae211194a44e0bf2fadc79e833881e45ea3eb2c2 > include/mesos/mesos.proto deb9c0910a27afd67276f54b3f666a878212727b > include/mesos/v1/executor/executor.proto > 36a2b3f9bc3aaa524f655b9e686a6d33512e6aaa > include/mesos/v1/mesos.proto a981e750c24cfc48177bbc9ca56f0c3ecfae1a1b > src/exec/exec.cpp 741786132f3a8cc43f5b9ced262429038832a946 > src/executor/executor.cpp 87db4e02cbaa778aab0173741bfe066fdee9a48d > src/slave/flags.cpp 4d10818105627738e258116647ccada374e3d7b9 > src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 > > Diff: https://reviews.apache.org/r/44655/diff/ > > > Testing > ------- > > The complete chain was tested. See https://reviews.apache.org/r/44662/. > > > Thanks, > > Alexander Rukletsov > >
