----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44703/#review124385 -----------------------------------------------------------
Fix it, then Ship it! Unnecessary summaries, but shippable once we remove those. include/mesos/authentication/http/basic_authenticator_factory.hpp (lines 38 - 40) <https://reviews.apache.org/r/44703/#comment186908> No need for the summary line above. Our doxygen config will auto-create a summary from the first sentence in the description, which says essentially the same thing. include/mesos/authentication/http/basic_authenticator_factory.hpp (lines 74 - 75) <https://reviews.apache.org/r/44703/#comment186909> Remove include/mesos/authentication/http/basic_authenticator_factory.hpp (lines 90 - 91) <https://reviews.apache.org/r/44703/#comment186910> Remove - Adam B On March 18, 2016, 11:13 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44703/ > ----------------------------------------------------------- > > (Updated March 18, 2016, 11:13 a.m.) > > > Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till > Toenshoff. > > > Bugs: MESOS-4849 > https://issues.apache.org/jira/browse/MESOS-4849 > > > Repository: mesos > > > Description > ------- > > Added Doxygen docs for basic HTTP authenticator. > > The structure of the module parameters for the basic HTTP authenticator has > changed, so Doxygen comments were added to the module's header file to > provide an example. > > > Diffs > ----- > > include/mesos/authentication/http/basic_authenticator_factory.hpp > c11bb47c8e02f2e8645cf387d18eb64d1c8cb604 > > Diff: https://reviews.apache.org/r/44703/diff/ > > > Testing > ------- > > > Thanks, > > Greg Mann > >
