> On March 12, 2016, 2:51 a.m., Avinash sridharan wrote: > > Can we introduce the protobuf before the `prepare` method patch?
Sure. > On March 12, 2016, 2:51 a.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/spec.proto, line 77 > > <https://reviews.apache.org/r/44622/diff/1/?file=1294411#file1294411line77> > > > > Can we insert an optional `name` field here to keep track of the > > `Network` this result is for? This should not break the JSON schema. I introduced a new struct `NetworkResultInfo` which has a `name` field, please see https://reviews.apache.org/r/44514/ for details. - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44622/#review123179 ----------------------------------------------------------- On March 16, 2016, 3:58 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44622/ > ----------------------------------------------------------- > > (Updated March 16, 2016, 3:58 p.m.) > > > Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu. > > > Bugs: MESOS-4759 > https://issues.apache.org/jira/browse/MESOS-4759 > > > Repository: mesos > > > Description > ------- > > Introduced a protobuf message "NetworkResult". > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/cni/spec.proto PRE-CREATION > > Diff: https://reviews.apache.org/r/44622/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Qian Zhang > >
