----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44672/#review123690 -----------------------------------------------------------
Please add a test to test if we can properly handle images like 'alpine' directly without the 'library/' prefix. src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp (line 175) <https://reviews.apache.org/r/44672/#comment185922> `path::join("library", _reference.repository()); - Jie Yu On March 14, 2016, 5:32 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44672/ > ----------------------------------------------------------- > > (Updated March 14, 2016, 5:32 p.m.) > > > Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen. > > > Bugs: MESOS-4877 > https://issues.apache.org/jira/browse/MESOS-4877 > > > Repository: mesos > > > Description > ------- > > Added normalize method to registry puller. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp > 6d637ed14f35feb554c8fcc63a7a7e046aaca574 > > Diff: https://reviews.apache.org/r/44672/diff/ > > > Testing > ------- > > make check > > sudo ./bin/mesos-test.sh > --gtest_filter="*ProvisionerDockerRegistryPullerTest*" > > > Thanks, > > Gilbert Song > >