----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44883/#review123830 -----------------------------------------------------------
Fix it, then Ship it! LGTM. Thanks for putting out a patch for this. Can you also add Jie as a reviewer and as a shepherd to the JIRA? src/uri/fetcher.cpp (lines 59 - 61) <https://reviews.apache.org/r/44883/#comment186118> Let's rephrase this as: "Skipping URI fetcher plugin 'name' as it could not be created: ....." - Anand Mazumdar On March 16, 2016, 3:31 a.m., Yong Tang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44883/ > ----------------------------------------------------------- > > (Updated March 16, 2016, 3:31 a.m.) > > > Review request for mesos and Anand Mazumdar. > > > Bugs: MESOS-4954 > https://issues.apache.org/jira/browse/MESOS-4954 > > > Repository: mesos > > > Description > ------- > > This fix changes the URL fetcher error message from LOG(ERROR) > to LOG(INFO) as the plugin is actually skipped if it is not > created. > > > Diffs > ----- > > src/uri/fetcher.cpp 8645b66f6c64c76b6c02ef0b9827a7d694d5ba97 > > Diff: https://reviews.apache.org/r/44883/diff/ > > > Testing > ------- > > make check (Ubuntu 14.04) > > > Thanks, > > Yong Tang > >
