-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45016/#review124199
-----------------------------------------------------------


Ship it!




Ship It!

- Joris Van Remoortere


On March 18, 2016, 5:39 a.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45016/
> -----------------------------------------------------------
> 
> (Updated March 18, 2016, 5:39 a.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Commit cf2ba377e95f8 vendored a more recent upstream version of the
> AX_CXX_COMPILE_STDCXX m4 macro. This new version changed behavior: the
> old version updated $CXXFLAGS to add the flags necessary to enable
> C++11 mode, while the new version updated $CXX.
> 
> Updating $CXX mostly works fine, except that for some reason Python's
> distutils uses $CC to compile C++ source files for a native Python
> extension. There's already a hack in `configure.ac` to add $CXXFLAGS
> to $CFLAGS to workaround this, but the hack stopped working when we
> stopped adding the C++ dialect flag to $CXXFLAGS.
> 
> For now, revert the m4 macro to update $CXXFLAGS instead of $CXX; in
> the future, it might also be worth looking into whether there's a way
> to convince distutils to be more sane.
> 
> 
> Diffs
> -----
> 
>   configure.ac a31f154198dc486d6ce0f58fecc35a1eb53b0ff5 
>   m4/ax_cxx_compile_stdcxx.m4 fa5463103b9bb641e8840abafe0c40cecf9999a0 
> 
> Diff: https://reviews.apache.org/r/45016/diff/
> 
> 
> Testing
> -------
> 
> "make check" with GCC 5.3
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Reply via email to