----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44975/#review124104 -----------------------------------------------------------
src/tests/containerizer/cgroups_tests.cpp (lines 1347 - 1349) <https://reviews.apache.org/r/44975/#comment186465> This comment doesn't make clear the real reason this is necessary. The reason is that without first clearing out the `"a *:* rwm"`, no matter how many devices you write to `devices.deny`, they will never show up in `devices.list` (because it's a whitelist). The cgroups driver for this is very simple and will only add/remove the **exact** entries you write to the respective `devices.allow` and `devices.deny` file. So tpo get **any** devices to ever show up in `devices.list`, you first have to clear out the `"a *:* rwm"` entry and then start allowing/denying devices explicitly. src/tests/containerizer/cgroups_tests.cpp (lines 1350 - 1353) <https://reviews.apache.org/r/44975/#comment186466> I probably wouldn't embed the `deny()` call inside the `CHECK_SOME()` call. I'd break them out into two separate calls as the rest of the cod ein this file does. src/tests/containerizer/cgroups_tests.cpp (line 1356) <https://reviews.apache.org/r/44975/#comment186468> You shouldn't need the `std::` here. src/tests/containerizer/cgroups_tests.cpp (lines 1357 - 1358) <https://reviews.apache.org/r/44975/#comment186467> Why the newline here? src/tests/containerizer/cgroups_tests.cpp (lines 1360 - 1368) <https://reviews.apache.org/r/44975/#comment186470> This pattern doesn't look very mesos-like to me. I'll defer to @bmahler or @nnielson for suggestions here. - Kevin Klues On March 17, 2016, 7:35 p.m., Abhishek Dasgupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44975/ > ----------------------------------------------------------- > > (Updated March 17, 2016, 7:35 p.m.) > > > Review request for mesos, Ben Mahler, Felix Abecassis, Kevin Klues, and > Niklas Nielsen. > > > Bugs: MESOS-3368 > https://issues.apache.org/jira/browse/MESOS-3368 > > > Repository: mesos > > > Description > ------- > > Updated cgroups test cases for cgroups device support. > > > Diffs > ----- > > src/tests/containerizer/cgroups_tests.cpp > acaed9b3f8a04964092cef413133834d0cf5a145 > > Diff: https://reviews.apache.org/r/44975/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Abhishek Dasgupta > >
