> On March 19, 2016, 10:49 a.m., Joerg Schad wrote: > > docs/configuration.md, line 1274 > > <https://reviews.apache.org/r/44554/diff/7/?file=1306425#file1306425line1274> > > > > dito.
Since the master's flag is '--credentials' rather than '--http_credentials', and they have slightly different uses, I think these should remain in the separate sections. > On March 19, 2016, 10:49 a.m., Joerg Schad wrote: > > docs/authentication.md, line 85 > > <https://reviews.apache.org/r/44554/diff/7/?file=1306424#file1306424line85> > > > > Do we have documentation for basic authenticator? We don't have module documentation for the basic authenticator module. This makes sense right now, since users won't use the basic authenticator as a module, they'll just let it load as the default. If we move to not having a default authenticator module in the future, then I think it will make sense to explicitly document the basic authenticator as a module. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44554/#review124398 ----------------------------------------------------------- On March 18, 2016, 7:30 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44554/ > ----------------------------------------------------------- > > (Updated March 18, 2016, 7:30 p.m.) > > > Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till > Toenshoff. > > > Bugs: MESOS-4850 > https://issues.apache.org/jira/browse/MESOS-4850 > > > Repository: mesos > > > Description > ------- > > Added agent HTTP authentication to the docs. > > > Diffs > ----- > > docs/authentication.md e7c0bf3ed331411f607e7622419f14853006a480 > docs/configuration.md d10fa2e7fc7c477de2f0e30e10da6d817ecbf404 > docs/home.md fd7794f56b4a95268dbb82288d99cab19a89f5cd > > Diff: https://reviews.apache.org/r/44554/diff/ > > > Testing > ------- > > Viewed with the Mesos website container: > https://github.com/mesosphere/mesos-website-container > > > Thanks, > > Greg Mann > >
