----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44747/#review124514 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/write.hpp (lines 25 - 28) <https://reviews.apache.org/r/44747/#comment187117> Would a `using` alias work here? 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/write.hpp (line 28) <https://reviews.apache.org/r/44747/#comment187115> space between `(const char*)` and `data`: `(const char*) data` 3rdparty/libprocess/3rdparty/stout/include/stout/os/write.hpp (line 48) <https://reviews.apache.org/r/44747/#comment187118> let's fix the missing `.` here 3rdparty/libprocess/3rdparty/stout/include/stout/os/write.hpp (line 88) <https://reviews.apache.org/r/44747/#comment187119> nice catch! - Joris Van Remoortere On March 17, 2016, 7:34 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44747/ > ----------------------------------------------------------- > > (Updated March 17, 2016, 7:34 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Bugs: MESOS-3641 > https://issues.apache.org/jira/browse/MESOS-3641 > > > Repository: mesos > > > Description > ------- > > Stout: Added implementation of `write` that works on Windows. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > 7bd4bfbc2ec5922879dcefddc12137336b11be52 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/write.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/stat.hpp > a2a5d0b7af673fee89f66e2722846af7b7fd059a > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/write.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/write.hpp > 1715bf5e6c590e7d14f59d517b30a281346365be > > Diff: https://reviews.apache.org/r/44747/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
