> On March 18, 2016, 11:24 p.m., Ben Mahler wrote:
> > src/tests/slave_tests.cpp, line 3264
> > <https://reviews.apache.org/r/44994/diff/2/?file=1306236#file1306236line3264>
> >
> >     You don't need a settle here, AWAIT_READY will settle if the clock is 
> > paused.

I feel that this is not obvious, that settle will happen in `AWAIT_READY` if 
clock is paused. Moreover, when we don't await, we have to explicitly settle, 
which—I think—makes it harder for folks to follow the test and reason when 
settle is necessary, because sometimes a necessary settle is implicit (inside 
await). Hence I tend to put explicit settles when I feel this makes the code 
more obvious. Do you have a strong preference?


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44994/#review124308
-----------------------------------------------------------


On March 18, 2016, 5:13 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44994/
> -----------------------------------------------------------
> 
> (Updated March 18, 2016, 5:13 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4949
>     https://issues.apache.org/jira/browse/MESOS-4949
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp ea1d776077bf638885db8421194aa4427c772169 
> 
> Diff: https://reviews.apache.org/r/44994/diff/
> 
> 
> Testing
> -------
> 
> On Mac OS 10.10.4:
> `make check`
> `GLOG_v=2 GTEST_FILTER="*SlaveTest*" ./bin/mesos-tests.sh --gtest_repeat=100 
> --gtest_break_on_failure`
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Reply via email to