----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45018/#review124601 -----------------------------------------------------------
Patch looks great! Reviews applied: [45018] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On March 21, 2016, 2:05 p.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45018/ > ----------------------------------------------------------- > > (Updated March 21, 2016, 2:05 p.m.) > > > Review request for mesos, Joris Van Remoortere and Joseph Wu. > > > Bugs: MESOS-3481 > https://issues.apache.org/jira/browse/MESOS-3481 > > > Repository: mesos > > > Description > ------- > > MESOS-3481 Add const accessor to Master flags. > > > Diffs > ----- > > src/master/master.hpp 124d43931a5c8a00ee0aaa604feb1761795209f2 > src/tests/master_tests.cpp d34ba0bdd71efd261850d8c205c16cecb701ac7c > > Diff: https://reviews.apache.org/r/45018/diff/ > > > Testing > ------- > > make check > > This getter is used to retrieve the flags from master. Currently, if one > wants to access master flags in the test, master flag has to be explicitly > created and then passed to `CreateMasterFlags(flags)`. > > story description: https://issues.apache.org/jira/browse/MESOS-3481 > > > Thanks, > > Jay Guo > >