----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45126/#review124683 -----------------------------------------------------------
Patch looks great! Reviews applied: [45126] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On March 21, 2016, 8:31 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45126/ > ----------------------------------------------------------- > > (Updated March 21, 2016, 8:31 p.m.) > > > Review request for mesos, Jie Yu and Timothy Chen. > > > Repository: mesos > > > Description > ------- > > This trivial change adds logic to only invoke the health checker > if the task has an associated health check set. This also cleans > up nested `if` block making it more readable. This also cleans > up the logic to just return if the health check subprocess cannot > be created. > > > Diffs > ----- > > src/launcher/executor.cpp 4149f084b0b234fb995df04e9d1ca704feec082e > > Diff: https://reviews.apache.org/r/45126/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >