> On March 16, 2016, 8:46 a.m., Vinod Kone wrote:
> > Can you explain what testing you have done in the "Testing done" section? 
> > 
> > According to MESOS-4312, we agreed to do the following tests:
> > 
> > -- Verify SSL, perf and docker related test cases work as expected on all 
> > platforms.
> > -- Do the validation on all platforms by "sudo make dist check" and "sudo 
> > make check --benchmark --gtest_filter="*Benchmark*"" and make sure the perf 
> > numbers are OK.
> > -- Run compatibility tests between scheduler <=> master <=> slave <=> 
> > executor where each of the components is running either the 
> > patched/upgraded version or not.
> 
> Zhiwei Chen wrote:
>     Thanks Vinod, I need to combine all patches and then test on Power 
> platform, so I planed only to test single patches on ubuntu/rhel/apple one by 
> one, after all patches go into upstream, I will create a patch to fix ppc64le 
> test cases[MESOS-4897]. Mesos code base changed, I need to rebase the patch 
> and then test again. Will update the Testing section when I am done.
> 
> Zhiwei Chen wrote:
>     Hi Vinod, when I do make check, I encouter this message many times, could 
> you tell me how to solve this?
>     
>     **1. This will cause the CgroupsNoHierarchyTest failed**
>     We cannot run any cgroups tests that require mounting
>     hierarchies because you have the following hierarchies mounted:
>     /sys/fs/cgroup/blkio, /sys/fs/cgroup/cpu, /sys/fs/cgroup/cpuacct, 
> /sys/fs/cgroup/cpuset, /sys/fs/cgroup/devices, /sys/fs/cgroup/freezer, 
> /sys/fs/cgroup/hugetlb, /sys/fs/cgroup/memory, /sys/fs/cgroup/net_cls, 
> /sys/fs/cgroup/net_prio, /sys/fs/cgroup/perf_event, /sys/fs/cgroup/systemd
>     We'll disable the CgroupsNoHierarchyTest test fixture for now.
>     
>     **2. I have no physical machine, so I can't do perf test**
>     The 'cpu-cycles' hardware event of 'perf' is not available on
>     this platform so tests using it will not be run.
>     One likely reason is that the tests are run in a virtual
>     machine that does not provide CPU performance counters
>     
>     **3. I use Ubuntu 14.04 as dev environment, so no overlayfs test**
>     
>     We cannot run any overlayfs tests because:
>     Overlayfs is not supported on your systems
> 
> Vinod Kone wrote:
>     Skipping the above tests is fine. 
>     
>     Can you make sure to run the benchmarks before and after? Also the 
> upgrade path (support/test_upgrade.py).
>     
>     Once you confirm, I will commit this. Then you can tackle the next 
> dependendcy upgrade. I would like us to do the ugprades in the order of least 
> disruption, so we can do glog and http parser next.

Thanks, I have done all the tests. But there is an issue, the 
./support/post-reviews.py can't submit binary file, so there will be no 
3rdparty/libprocess/3rdparty/libev-4.22.tar.gz file in the repo, I think you 
can fix this.


- Zhiwei


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44378/#review123812
-----------------------------------------------------------


On March 22, 2016, 9:38 a.m., Zhiwei Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44378/
> -----------------------------------------------------------
> 
> (Updated March 22, 2016, 9:38 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-4803
>     https://issues.apache.org/jira/browse/MESOS-4803
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Upgrade libev to 4.22 to support PowerPC LE platform.
> 
> 
> Diffs
> -----
> 
>   3rdparty/cmake/Versions.cmake 24490d399f20b31b6336e92d1bd5d9a7230f31f7 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt 
> 6b07aefc58a1daa235b35e83832e47d1878e2e94 
>   3rdparty/libprocess/3rdparty/libev-4.15.patch 
> bbd83e6928e6caba3bc5a9739823d60923cfaa2a 
>   3rdparty/libprocess/3rdparty/libev-4.15.tar.gz 
> 4c282b573aa9331fd16197ef286faf323b6515eb 
>   3rdparty/libprocess/3rdparty/libev-4.22.patch PRE-CREATION 
>   3rdparty/libprocess/3rdparty/libev-4.22.tar.gz PRE-CREATION 
>   3rdparty/libprocess/3rdparty/versions.am 
> 98195b8eb60b2673d610d8ab7ea31103f137debf 
>   LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 
>   src/python/native_common/ext_modules.py.in 
> c335bd83024bc07b6243dd59d775e7f29adc7520 
> 
> Diff: https://reviews.apache.org/r/44378/diff/
> 
> 
> Testing
> -------
> 
> sudo make dist check
> 
> sudo ./src/mesos-tests --benchmark
> 
> sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Reply via email to