----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45134/#review124785 -----------------------------------------------------------
Fix it, then Ship it! Ship It! src/tests/environment.cpp (line 253) <https://reviews.apache.org/r/45134/#comment187444> Suggest put after `RootFilter` as well. src/tests/environment.cpp (line 697) <https://reviews.apache.org/r/45134/#comment187443> Could you put this after ``` filters.push_back(Owned<TestFilter>(new RootFilter())); ``` I think it should ordered alphabetically. - haosdent huang On March 22, 2016, 12:27 p.m., Tomasz Janiszewski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45134/ > ----------------------------------------------------------- > > (Updated March 22, 2016, 12:27 p.m.) > > > Review request for mesos, Jie Yu and Neil Conway. > > > Bugs: MESOS-4993 > https://issues.apache.org/jira/browse/MESOS-4993 > > > Repository: mesos > > > Description > ------- > > Skip FetcherTest zip tests when `unzip` is uninstalled. > > > Diffs > ----- > > src/tests/environment.cpp ee1bbe6b4e3dda1e27b63d71a08ef0d1d254741a > src/tests/fetcher_tests.cpp 375e690ead4f954a66a6efc2f2daa7fb1f1a024d > > Diff: https://reviews.apache.org/r/45134/diff/ > > > Testing > ------- > > > Thanks, > > Tomasz Janiszewski > >
