> On March 22, 2016, 5:50 p.m., Ben Mahler wrote:
> > The changelog update would be great as well here, I'll take care of that 
> > before committing. Thanks!

I'll also update the existing test:

```
$ grep -R allocator/event_queue_dispatches src/tests
src/tests/master_tests.cpp:  EXPECT_EQ(1u, 
snapshot.values.count("allocator/event_queue_dispatches"));
```


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44851/#review124840
-----------------------------------------------------------


On March 22, 2016, 5:32 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44851/
> -----------------------------------------------------------
> 
> (Updated March 22, 2016, 5:32 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-5001
>     https://issues.apache.org/jira/browse/MESOS-5001
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Since allocators can be replaced with a custom module instead use a
> name clearly communicating that the metrics reported here are related
> to the default (hierarchical) allocator.
> 
> For backwards compatibility we continue to support the old metrics
> name.
> 
> 
> Diffs
> -----
> 
>   docs/upgrades.md 83b839f7fb996385baaa6ef1081dc1116cd6e338 
>   src/master/allocator/mesos/metrics.hpp 
> d04e9a11c77b6fb2d522608e3085f81f8a6657ca 
>   src/master/allocator/mesos/metrics.cpp 
> 46dd7f7b3d8d49c59b42e789fe5dcd49f1693ace 
> 
> Diff: https://reviews.apache.org/r/44851/diff/
> 
> 
> Testing
> -------
> 
> check make check (OS X, clang-trunk) here and with later patches using other 
> allocator metrics.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Reply via email to