-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45022/#review124867
-----------------------------------------------------------




3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rm.hpp (lines 49 - 
53)
<https://reviews.apache.org/r/45022/#comment187562>

    ```
      const BOOL result = os::stat::isdir(path) ? 
::RemoveDirectory(path.c_str())
                                                : ::DeleteFile(path.c_str());
    ```



3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp (line 200)
<https://reviews.apache.org/r/45022/#comment187571>

    Why do we need this? I would much prefer to remove this.



3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp (lines 239 - 
243)
<https://reviews.apache.org/r/45022/#comment187569>

    I understand the comment, but why re-build the expected set from scratch?
    
    That is, I see the pairing of `mkdir` + `insert`, `touch` + `insert`, etc. 
Why not pair up `rm` + `erase`?



3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp (line 247)
<https://reviews.apache.org/r/45022/#comment187570>

    `s/ASSERT_ERROR/EXPECT_ERROR/`


- Michael Park


On March 18, 2016, 7:39 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45022/
> -----------------------------------------------------------
> 
> (Updated March 18, 2016, 7:39 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-4415
>     https://issues.apache.org/jira/browse/MESOS-4415
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We currently depend on arcane "POSIX-like" Windows APIs like `::remove`.
> This API is incompatible with NT paths -- which we will eventually have
> to transition to for the Windows integration -- and has no documented
> behavior interacting with subsystems like the driver subsystem, which is
> required for symlinks.
> 
> This commit will move us to proper core Windows API equivalents for
> `::remove`.
> 
> Review: https://reviews.apache.org/r/45022
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 7bd4bfbc2ec5922879dcefddc12137336b11be52 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rm.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/rm.hpp 
> 52568b303c03fd57b81f6cc67782444ce734dd41 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rm.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp 
> 4c30189bb8261ccfc699da0f31b8b1fd3e9b3c83 
> 
> Diff: https://reviews.apache.org/r/45022/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Reply via email to