> On March 22, 2016, 11:02 p.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/isolators/docker/runtime.cpp, lines 216-222 > > <https://reviews.apache.org/r/45183/diff/1/?file=1311192#file1311192line216> > > > > This was already checked in L194-L197, why check again here?
Hey Guangya, thanks for prompt review feedbacks. Will have above two fixed tomorrow morning:). I planned to introduce an agent flag and insert the logic on L202, but did not have them with this patch because of hesitation on flag naming at that time. Should have left a TODO there and delete it later. Sorry for the inconvenience. > On March 22, 2016, 11:02 p.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/isolators/docker/runtime.cpp, lines 156-162 > > <https://reviews.apache.org/r/45183/diff/1/?file=1311192#file1311192line156> > > > > Can we move this logic to L134-L152? Sure, thanks. > On March 22, 2016, 11:02 p.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/isolators/docker/runtime.cpp, line 207 > > <https://reviews.apache.org/r/45183/diff/1/?file=1311192#file1311192line207> > > > > s/containerConfig.rootfs()/rootfs Good catch. - Gilbert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45183/#review124961 ----------------------------------------------------------- On March 22, 2016, 5:20 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45183/ > ----------------------------------------------------------- > > (Updated March 22, 2016, 5:20 p.m.) > > > Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy > Chen. > > > Bugs: MESOS-3003 > https://issues.apache.org/jira/browse/MESOS-3003 > > > Repository: mesos > > > Description > ------- > > Implemented mounting host system config files to container. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/docker/runtime.hpp > 90179119ef297855091dad3fe969aa79810bf209 > src/slave/containerizer/mesos/isolators/docker/runtime.cpp > f97a9a92895387a9d504810a2ae971cfb5d3dbb4 > > Diff: https://reviews.apache.org/r/45183/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
