> On March 21, 2016, 10:28 a.m., Adam B wrote: > > src/slave/http.cpp, lines 351-354 > > <https://reviews.apache.org/r/45036/diff/1/?file=1306183#file1306183line351> > > > > Looks like `Master::Http::FLAGS_HELP()` is incorrectly using > > AUTHENTICATION() as its DESCRIPTION parameter.. Amirite? > > Adam B wrote: > > https://github.com/apache/mesos/blob/master/docs/endpoints/master/flags.md#description > "DESCRIPTION > > This endpoint requires authentication iff HTTP authentication is enabled." > > Adam B wrote: > Definitely messed up master flags endpoint help, but I/we can fix that in > a separate patch. Dropping.
Fixed with https://reviews.apache.org/r/45204/ - Joerg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45036/#review124525 ----------------------------------------------------------- On March 21, 2016, 10:22 a.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45036/ > ----------------------------------------------------------- > > (Updated March 21, 2016, 10:22 a.m.) > > > Review request for mesos, Adam B and Greg Mann. > > > Repository: mesos > > > Description > ------- > > Agent endpoint help now displays information whether authentication (if > enabled) is required in HELP. > > > Diffs > ----- > > src/slave/http.cpp 4eb1fafdfa72094511b0b2684a3c2705bd8c7c5e > > Diff: https://reviews.apache.org/r/45036/diff/ > > > Testing > ------- > > Checked agent help endpoint. > > > Thanks, > > Joerg Schad > >
