-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44089/#review125012
-----------------------------------------------------------




3rdparty/libprocess/src/io.cpp (line 76)
<https://reviews.apache.org/r/44089/#comment187756>

    space between `(char*)` and `data`



3rdparty/libprocess/src/io.cpp (lines 86 - 87)
<https://reviews.apache.org/r/44089/#comment187761>

    This behavior is not quite consistent:
    see my comment in https://reviews.apache.org/r/44138/



3rdparty/libprocess/src/io.cpp (line 87)
<https://reviews.apache.org/r/44089/#comment187757>

    indentation.



3rdparty/libprocess/src/io.cpp (line 147)
<https://reviews.apache.org/r/44089/#comment187758>

    indentation.


- Joris Van Remoortere


On March 21, 2016, 10:54 p.m., Daniel Pravat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44089/
> -----------------------------------------------------------
> 
> (Updated March 21, 2016, 10:54 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex 
> Clemmer, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Used os::read/write from Stout for proper OS isolation.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/io.cpp 4a58d6dff3787ca262ee2ade2cbea7578ad27e95 
> 
> Diff: https://reviews.apache.org/r/44089/diff/
> 
> 
> Testing
> -------
> 
> OSX: make check
> Windows: build/run
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Reply via email to