----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45093/#review125094 -----------------------------------------------------------
Fix it, then Ship it! src/tests/containerizer/mesos_containerizer_tests.cpp (line 821) <https://reviews.apache.org/r/45093/#comment187838> Space after `)` src/tests/containerizer/mesos_containerizer_tests.cpp (line 835) <https://reviews.apache.org/r/45093/#comment187839> Can you add a `using` clause instead: ``` using mesos::internal::slave::ProvisionInfo; ``` src/tests/containerizer/mesos_containerizer_tests.cpp (line 863) <https://reviews.apache.org/r/45093/#comment187840> Use UUID::random() src/tests/containerizer/mesos_containerizer_tests.cpp (line 902) <https://reviews.apache.org/r/45093/#comment187841> Remove the namespace qualifiers - Jie Yu On March 21, 2016, 5:51 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45093/ > ----------------------------------------------------------- > > (Updated March 21, 2016, 5:51 a.m.) > > > Review request for mesos, Artem Harutyunyan, Jie Yu, Shuai Lin, and Timothy > Chen. > > > Bugs: MESOS-4985 > https://issues.apache.org/jira/browse/MESOS-4985 > > > Repository: mesos > > > Description > ------- > > Added mesos containerizer test DestroyWhileProvisioning. > > > Diffs > ----- > > src/tests/containerizer/mesos_containerizer_tests.cpp > f3ca32b2d8b8ef9dcfa8f20d9ceaff48b6598a66 > > Diff: https://reviews.apache.org/r/45093/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
