> On March 11, 2016, 6:19 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni.cpp, line 228 > > <https://reviews.apache.org/r/44514/diff/2/?file=1294398#file1294398line228> > > > > Can there be a use case where you want multiple NICs to be attached to > > the same network? Servers use this configuration when they want to utilize > > NIC bonding. To aggregate the bandwidth available on the NICs > > Qian Zhang wrote: > Good point! I think it makes sense that user enables NIC bonding by > creating a bond device (e.g., bond0) as the master of the normal ethernet > devices (e.g., eth0 and eth1), and both eth0 and eth1 are set up by CNI > plugin and get assigned IP from CNI plugin in the same subnet. My only > concern is, how to configure the IP for bond0, maybe just use IP of either > eth0 or eth1 as its IP? > > Avinash sridharan wrote: > I think for the time being we can leave the behavior as is. To support > something like NIC bonding, I think we will need to introduce the concept of > `repeated` devices in `NetworkInfo`, which is definitely out of the scope of > this work.
Bonding is a L2 device as a whole, therefore you should just set IP address on the bonding master, its slaves don't need IP addresses. - Cong ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44514/#review123176 ----------------------------------------------------------- On March 23, 2016, 5:10 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44514/ > ----------------------------------------------------------- > > (Updated March 23, 2016, 5:10 a.m.) > > > Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu. > > > Bugs: MESOS-4759 > https://issues.apache.org/jira/browse/MESOS-4759 > > > Repository: mesos > > > Description > ------- > > Implemented prepare() method of "network/cni" isolator. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp > 3878a7e85fe24175b3bd5e3a6268cf32a07f2d8b > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > 9552312f9ba1e4df6564cfb737cc41e041cf4407 > > Diff: https://reviews.apache.org/r/44514/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Qian Zhang > >
