----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45249/#review125209 -----------------------------------------------------------
Patch looks great! Reviews applied: [44678, 44703, 44515, 44523, 44553, 44554, 45088, 45248, 45249] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On March 24, 2016, 1:05 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45249/ > ----------------------------------------------------------- > > (Updated March 24, 2016, 1:05 a.m.) > > > Review request for mesos, Adam B, Ben Mahler, and Joerg Schad. > > > Bugs: MESOS-4956 > https://issues.apache.org/jira/browse/MESOS-4956 > > > Repository: mesos > > > Description > ------- > > New tests were added to the FilesTests, and existing tests were modified, to > probe the endpoints' behavior with and without HTTP authentication. Tests > were also added for `/flags/debug`, as there were no pre-existing tests for > that endpoint. > > > Diffs > ----- > > src/tests/files_tests.cpp b3894954e32b14f879f24fac17869fc32ad2ce0e > > Diff: https://reviews.apache.org/r/45249/diff/ > > > Testing > ------- > > `sudo make check` was used to test on OSX and CentOS 7. > > > Thanks, > > Greg Mann > >