> On March 16, 2016, 4:22 a.m., Benjamin Bannier wrote:
> > src/slave/containerizer/mesos/isolators/docker/runtime.cpp, line 160
> > <https://reviews.apache.org/r/44500/diff/1/?file=1291044#file1291044line160>
> >
> >     Does it makes sense to distinguish the sources of overwriting here and 
> > in l.179ff below?

They are different. This one is the environment from image, and the latter one 
is from the user. We have to prevent the case that image env are dulplicate 
themselves, and the case that image env duplicates user's.


- Gilbert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44500/#review123852
-----------------------------------------------------------


On March 24, 2016, 3:01 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44500/
> -----------------------------------------------------------
> 
> (Updated March 24, 2016, 3:01 p.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy 
> Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented passing image and user env var to command task.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/docker/runtime.cpp 
> f97a9a92895387a9d504810a2ae971cfb5d3dbb4 
> 
> Diff: https://reviews.apache.org/r/44500/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Reply via email to