----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44087/#review125512 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/linux_launcher.cpp (line 251) <https://reviews.apache.org/r/44087/#comment188329> new line before the `NOTE:` src/slave/containerizer/mesos/linux_launcher.cpp (line 305) <https://reviews.apache.org/r/44087/#comment188330> `NOTE: The child process...` src/slave/containerizer/mesos/linux_launcher.cpp (lines 315 - 324) <https://reviews.apache.org/r/44087/#comment188332> why not create the lambda inline? src/slave/containerizer/mesos/linux_launcher.cpp (line 317) <https://reviews.apache.org/r/44087/#comment188331> Can we follow the explicit address `&` pattern here? src/slave/containerizer/mesos/linux_launcher.cpp (lines 322 - 323) <https://reviews.apache.org/r/44087/#comment188333> maybe put this comment above the first hook? The `at this point` is confusing based on the explicit position of the comment. - Joris Van Remoortere On March 14, 2016, 3:44 p.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44087/ > ----------------------------------------------------------- > > (Updated March 14, 2016, 3:44 p.m.) > > > Review request for mesos and Joris Van Remoortere. > > > Bugs: MESOS-4839 > https://issues.apache.org/jira/browse/MESOS-4839 > > > Repository: mesos > > > Description > ------- > > Previously assigning the process to the freezer hierarchy basically > reimplemented the same blocking and error handling logic provided by > parentHooks. > > > Diffs > ----- > > src/slave/containerizer/mesos/linux_launcher.cpp > 9c80cfb621ef2e28aabfb2649846892964d2d4f3 > > Diff: https://reviews.apache.org/r/44087/diff/ > > > Testing > ------- > > sudo make check (on Linux) > > > Thanks, > > Joerg Schad > >
