-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44843/#review125535
-----------------------------------------------------------




src/exec/exec.cpp (lines 637 - 638)
<https://reviews.apache.org/r/44843/#comment188382>

    This is clearly beyond just a `s/NULL/nullptr`. I assume this is 
`clang-tidy` magic, right?



src/linux/fs.cpp (lines 587 - 589)
<https://reviews.apache.org/r/44843/#comment188390>

    ```
      Try<Nothing> mount =
        fs::mount(None(), "/", None(), MS_REC | MS_SLAVE, nullptr);
        
      if (mount.isError()) {
        ...
      }
    ```



src/python/executor/src/mesos/executor/proxy_executor.cpp (lines 54 - 55)
<https://reviews.apache.org/r/44843/#comment188393>

    Hm, how come these `NULL`s were not replaced?



src/python/scheduler/src/mesos/scheduler/proxy_scheduler.cpp (line 335)
<https://reviews.apache.org/r/44843/#comment188394>

    What about the `NULL` here?



src/tests/script.cpp (line 96)
<https://reviews.apache.org/r/44843/#comment188395>

    Another instance of `NULL` not being replaced?



src/tests/zookeeper_test_server.cpp (line 115)
<https://reviews.apache.org/r/44843/#comment188396>

    Another instance of `NULL` not replaced.


- Michael Park


On March 15, 2016, 9:15 a.m., Tomasz Janiszewski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44843/
> -----------------------------------------------------------
> 
> (Updated March 15, 2016, 9:15 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-3243
>     https://issues.apache.org/jira/browse/MESOS-3243
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replace NULLs with `run-clang-tidy.py` and then with sed
> 
> 
> Diffs
> -----
> 
>   src/authentication/cram_md5/authenticatee.cpp 
> 7d4994333428e5d8aa9ce6b85e0a7f42a0ddc4c8 
>   src/authentication/cram_md5/authenticator.cpp 
> 027eba4f433fff328d68c41005bc59c41c7ae668 
>   src/authentication/cram_md5/auxprop.cpp 
> d82d2d2f7793859772d89cc91bee09240624c613 
>   src/authorizer/local/authorizer.cpp 
> 0f0d9276337858984f0b19a82ffca74ee84dc650 
>   src/examples/balloon_executor.cpp 399218478a596387814d123290eeeb33102fad7a 
>   src/examples/example_module_impl.cpp 
> aeffdc0e95fa7badc8cfa09e2b57462e427fec55 
>   src/examples/load_generator_framework.cpp 
> 7d64b6617564f43ef383ee60d92da92b2c958c47 
>   src/examples/test_allocator_module.cpp 
> 1255a4a22a9d1a5724bef78dfc4dee498ed50fff 
>   src/examples/test_anonymous_module.cpp 
> dd291cff3b5d47337e371cd2c1082fd6716af3fc 
>   src/examples/test_authorizer_module.cpp 
> 19ec7cd114562f74c660b83b39235127d25001ee 
>   src/examples/test_container_logger_module.cpp 
> 76dd494fa4c32514ba14b1f4498b588ac9051b4d 
>   src/examples/test_hook_module.cpp abd132b3f39265683542a9d1533d2a31bd81769a 
>   src/examples/test_http_authenticator_module.cpp 
> 459b7046bd76d3043d2484a2dd30c10d7deaedd4 
>   src/examples/test_isolator_module.cpp 
> a4a2103b1e449837b95948c8b5c25e05c5d13860 
>   src/examples/test_qos_controller_module.cpp 
> f382fc443fa0a4545ba78dc28016e4d0a0dd16b1 
>   src/examples/test_resource_estimator_module.cpp 
> 229b2931e9129c194850f04051060d33bfa06570 
>   src/exec/exec.cpp 741786132f3a8cc43f5b9ced262429038832a946 
>   src/java/jni/construct.cpp 0bfe6291e94a69a787c965fa3a3a90d2ebae8d72 
>   src/java/jni/convert.cpp f1a486d8d2f6d43efd89407c928734bd9715e591 
>   src/java/jni/org_apache_mesos_Log.cpp 
> 140b950136417eed7cba363a89537ed2f33832ff 
>   src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 
> 9a92ade5d54bd814353acb40170d7aa4d8fe4a77 
>   src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 
> c723e2d7bce98e6ac5ab587ce8c42fa9ba8b47e4 
>   src/java/jni/org_apache_mesos_state_AbstractState.cpp 
> 4fd43ca31c6917e81ea1b331b8507ca42a2249cf 
>   src/java/jni/org_apache_mesos_state_Variable.cpp 
> 7a69b3d878e6eaa87bfaf56c0500e11efe4ac44d 
>   src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp 
> 23a89c3e5c5309a8a9b45c168fb61b12d89db1ec 
>   src/jvm/jvm.cpp 909d34a0112b219456dce76126029c603077e66d 
>   src/launcher/executor.cpp 4149f084b0b234fb995df04e9d1ca704feec082e 
>   src/linux/cgroups.cpp df18ed46a2a96871f67c7eb4233c3b4c27b7aa1c 
>   src/linux/fs.cpp dbf94759b6382bfafd3f3b8b4c2047af36a53ad5 
>   src/linux/perf.cpp 1c113a2b3f57877e132bbd65e01fb2f045132128 
>   src/linux/routing/diagnosis/diagnosis.cpp 
> 8b86a8864c08b078425dcc242d323763d6ec15dd 
>   src/linux/routing/route.cpp 4b33350dc3761e19121c29c0d090cfdae544e4ef 
>   src/linux/systemd.cpp e120d2ceffe6bb400859f2a132f02a99f561f856 
>   src/local/local.cpp f8599e7378e9a0065bbd01ad8f23f11debb30c91 
>   src/log/leveldb.cpp ba2f62bc97e4a0eaa8a54824551686467db4b9e4 
>   src/log/log.cpp a37676068dae14b1adc61ef75e2742c16e7a6e42 
>   src/log/tool/benchmark.cpp 770c6d85fec76826ca8369b2afc721c07899e32f 
>   src/log/tool/initialize.cpp bd1e9ef1922ae972a5999b6e7412e08eac92c1ac 
>   src/log/tool/read.cpp b9e90e44c8cd7351767e523af338d8c662e0848c 
>   src/log/tool/replica.cpp 49415821a32960c78192b89f9a0f2067b9157a63 
>   src/logging/logging.cpp 8d9e4e9b200a0df1c67d4e7cd57107b7780f9812 
>   src/master/contender.cpp 9ad49ce10439fb41d78d52eaa4c1e6b9c5c7f735 
>   src/master/http.cpp 1c2ca334567611578d9c6edb9ee7b0f43f0f1e18 
>   src/master/main.cpp 7c1656bcc266f6c94cb4befad37fa813a218b2fa 
>   src/master/master.cpp d0380db3b90a9166607445f8dd50cc63d547228e 
>   src/master/validation.cpp 820a9faee6fde09a98317854b181fe897167e2ca 
>   src/module/manager.cpp 8c9aaf7cd00c904daba9994a99df9e1329831c01 
>   src/python/executor/src/mesos/executor/mesos_executor_driver_impl.cpp 
> 843771ae5b4f7e283d85c093e63c235dc753397d 
>   src/python/executor/src/mesos/executor/module.cpp 
> f8c63821db616475b95c3d1687893c251fa2daca 
>   src/python/executor/src/mesos/executor/proxy_executor.cpp 
> b9c8a2d131e5aadf6fa79af023bb34ae5a3cebba 
>   src/python/scheduler/src/mesos/scheduler/mesos_scheduler_driver_impl.cpp 
> 78dc298ec19a61cd491b2b43b463db67528c5526 
>   src/python/scheduler/src/mesos/scheduler/module.cpp 
> 62eaf3166c4ebef42665358e8da438b2e3afba20 
>   src/python/scheduler/src/mesos/scheduler/proxy_scheduler.cpp 
> 3d8f3bfc9cbff761822580310432177d00450f51 
>   src/sched/sched.cpp 525255eec808c3fe5c0e38b3d1a2086bbd4eb171 
>   src/scheduler/scheduler.cpp 35f479483740baed3f7bdbf45bf1d5bba3b9febc 
>   src/slave/container_logger.cpp 85b8c1d3a42baba14741996d791926816b252742 
>   src/slave/container_loggers/lib_logrotate.cpp 
> cf5f238eb3b6217b848cf23f8c9cd1848bf9a9f0 
>   src/slave/container_loggers/logrotate.cpp 
> 7d36c052ff7a180b45ca265fb7ff4c6900d98d64 
>   src/slave/containerizer/docker.cpp fb9188a19a5cd8211d4f36f9647ebb70de560109 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
> 9fc7c48f99155750fd3c18c7c102507e2726362b 
>   src/slave/containerizer/mesos/isolators/namespaces/pid.cpp 
> 5970d22e7198236d22c55de6153f465ed5f5fd7a 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
> 134b6c759b769cf335539e49eff817973c7f96a4 
>   src/slave/containerizer/mesos/launch.cpp 
> dc7bebf8d0f3e36c6d41af4e0e8ffc438b6cd86c 
>   src/slave/containerizer/mesos/mount.cpp 
> bf17b015e45579882fd31248e8609eec6d58a9da 
>   src/slave/containerizer/mesos/provisioner/backends/bind.cpp 
> 9b9f0b9e99a0fc0e9bad8fb2dad41acdc0ca1da1 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.cpp 
> 5cc0f8b5a8cd4c945023f874056a8184113186c5 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 
> 8a4938ebe4e00779e88e7c538445e9ffd51202e2 
>   src/slave/http.cpp 4eb1fafdfa72094511b0b2684a3c2705bd8c7c5e 
>   src/slave/qos_controllers/load.cpp dd44f9209ad283bfea95f16a8c1017e309757f23 
>   src/slave/qos_controllers/noop.cpp dc40f43e89212b77611522b0794c675a5ea1c53e 
>   src/slave/resource_estimators/fixed.cpp 
> c858a48bc137185d1e1e24a20f6b75b0dd7912ff 
>   src/slave/resource_estimators/noop.cpp 
> 66c646def36c1050b01d55f9fe6561ca5eed6148 
>   src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 
>   src/slave/status_update_manager.cpp 
> f6a9b3b6616abee9c55bf731855ee9b3b98606ac 
>   src/state/leveldb.cpp 4988aa1770836d450af7446764c4a27fc28e0017 
>   src/state/zookeeper.cpp e3df3ee9a2e8193b3d96e3d3280d31bae4d3972e 
>   src/tests/container_logger_tests.cpp 
> 00f4129e46aa9268fbb66da25b34e61004fa87b2 
>   src/tests/containerizer/cgroups_tests.cpp 
> acaed9b3f8a04964092cef413133834d0cf5a145 
>   src/tests/containerizer/memory_test_helper.cpp 
> 92579a28336b3c15ba7fdbb4a9f769ac7182aeb6 
>   src/tests/containerizer/routing_tests.cpp 
> 4ebb01213ce20f954c2633df95e898cf66a2d9e9 
>   src/tests/environment.cpp ee1bbe6b4e3dda1e27b63d71a08ef0d1d254741a 
>   src/tests/group_tests.cpp ed10f1fe8a5cd2a353175e13ec3c464da69956f4 
>   src/tests/master_contender_detector_tests.cpp 
> 255ab8119a04b55bb4f1b61dee19c4be64499376 
>   src/tests/mesos.cpp 7cca4ed4753fa365b209d1d22f0df4650b19bc6a 
>   src/tests/module_tests.cpp eddb0e5484964595797758e2742b10431e76c039 
>   src/tests/registrar_tests.cpp c330af2a190282e159d9ab477cdc36a7881842cd 
>   src/tests/script.cpp 36ddf40fc003435f852ca138f66c4f33def1637b 
>   src/tests/slave_tests.cpp 87c5e8caa63095fb8325ae019041398d49aa1edf 
>   src/tests/state_tests.cpp 8fb2798e12fe77d6b93268e71e3a8261cb0842d5 
>   src/tests/zookeeper_test_server.cpp 
> 0dc041fef8973d35114b9f76a6a4002853884670 
>   src/tests/zookeeper_tests.cpp 6bde10b9ae9a644d3506abb285786200dc2fbe94 
>   src/zookeeper/group.cpp 7aa95a7b7eafe0a2c49dc077b3a4abd688e5d8e8 
>   src/zookeeper/zookeeper.cpp 02fa158a37ddaf045bdf6403c134d03a02c74833 
> 
> Diff: https://reviews.apache.org/r/44843/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Reply via email to