----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45232/#review125676 -----------------------------------------------------------
3rdparty/libprocess/include/process/subprocess.hpp (line 46) <https://reviews.apache.org/r/45232/#comment188543> When did we start making 'enum' names be in caps? There is an enum 7 lines above that is not in all caps. - Benjamin Hindman On March 28, 2016, 4:52 p.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45232/ > ----------------------------------------------------------- > > (Updated March 28, 2016, 4:52 p.m.) > > > Review request for mesos and Joris Van Remoortere. > > > Bugs: MESOS-5049 > https://issues.apache.org/jira/browse/MESOS-5049 > > > Repository: mesos > > > Description > ------- > > Some newly created processes such as perf should be killed in case the > parent dies. Currently this is achieved by forking a new process from the > child process which serves as a 'watchdog' and kill the child if the parent > dies. This review introduces this as a general behavior into subprocess > (and hence removes the need for the custom setup function). > > > Diffs > ----- > > 3rdparty/libprocess/include/process/subprocess.hpp > e0c306aa5cf5f393abb73768bbd287c45730f076 > 3rdparty/libprocess/src/subprocess.cpp > b99bad04f7251169df3bfcec5dee459977440997 > 3rdparty/libprocess/src/tests/subprocess_tests.cpp > 09e46eb1ce10a6c38cc364077f0b5952579d46e7 > > Diff: https://reviews.apache.org/r/45232/diff/ > > > Testing > ------- > > Tested complete chain (see https://reviews.apache.org/r/45236/). > > > Thanks, > > Joerg Schad > >
