> On March 26, 2016, 7:43 p.m., Daniel Pravat wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp, line 56 > > <https://reviews.apache.org/r/45310/diff/1/?file=1314158#file1314158line56> > > > > Without additional context the reviewer may think that this change will > > break the build. Maybe you can change the order between this review and the > > next or eliminate the constructors in the next commit.
This is ordered this way, because once the `Error` is templated, it might not be possible to have ctors that take `ErrnoError` and `WindowsError`. Simply fixing a hack that was introduced before, to set the table for the subsequent changes. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45310/#review125546 ----------------------------------------------------------- On March 24, 2016, 8:22 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45310/ > ----------------------------------------------------------- > > (Updated March 24, 2016, 8:22 p.m.) > > > Review request for mesos, Alex Clemmer and Joris Van Remoortere. > > > Repository: mesos > > > Description > ------- > > Correctly constrained the templated constructor. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp > c444c0118d39ee6a5da4618d7c62784464377280 > > Diff: https://reviews.apache.org/r/45310/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Michael Park > >
