----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42861/#review125802 -----------------------------------------------------------
It would be good to have a unit test for the end-to-end behavior (i.e., we have a test for `path::overlapping` in the other RR, but we should also have a test for trying to create two volumes with overlapping paths). src/slave/slave.cpp (line 504) <https://reviews.apache.org/r/42861/#comment188683> Comment should be updated if we're going to do this even when you're not "verifying against the mount table entries". src/slave/slave.cpp (line 552) <https://reviews.apache.org/r/42861/#comment188681> Error message shouldn't end in punctuation. - Neil Conway On March 29, 2016, 2:30 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42861/ > ----------------------------------------------------------- > > (Updated March 29, 2016, 2:30 a.m.) > > > Review request for mesos, Benjamin Bannier, Jie Yu, Joris Van Remoortere, and > Neil Conway. > > > Bugs: MESOS-4521 > https://issues.apache.org/jira/browse/MESOS-4521 > > > Repository: mesos > > > Description > ------- > > Ensure two Mount Disk resources do not have the same root path. > > > Diffs > ----- > > src/slave/slave.cpp f383605a52f31d7b805ad6153adc409dcb40f83a > > Diff: https://reviews.apache.org/r/42861/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
