-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42860/#review125801
-----------------------------------------------------------



Made a few quick comments. I didn't look at the `CheckOverlapTree` logic itself 
yet though.


3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp (line 33)
<https://reviews.apache.org/r/42860/#comment188676>

    Semicolon seems unnecessary.



3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp (line 53)
<https://reviews.apache.org/r/42860/#comment188677>

    Semicolon seems unnecessary.



3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp (line 126)
<https://reviews.apache.org/r/42860/#comment188679>

    Can we clarify what "overlapping" means here?



3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp (line 127)
<https://reviews.apache.org/r/42860/#comment188680>

    What does "flat" mean, here? Also, is it worth adding a `CHECK` that all 
paths are absolute?



3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp (line 128)
<https://reviews.apache.org/r/42860/#comment188678>

    Should probably be `const std::vector<std::string>&`.


- Neil Conway


On March 29, 2016, 2:30 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42860/
> -----------------------------------------------------------
> 
> (Updated March 29, 2016, 2:30 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jie Yu, Joris Van Remoortere, and 
> Neil Conway.
> 
> 
> Bugs: MESOS-4521
>     https://issues.apache.org/jira/browse/MESOS-4521
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add paths::overlapping to check whether paths are overlapping.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp 
> ef538045a8b7a1e3d8962c869317d86a85e0259f 
>   3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp 
> 6dff5e76e0e15098c5a262adc50bfcb65f933697 
> 
> Diff: https://reviews.apache.org/r/42860/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Reply via email to