----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45410/#review125843 -----------------------------------------------------------
Patch looks great! Reviews applied: [45408, 45409, 45410] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On March 29, 2016, 12:19 a.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45410/ > ----------------------------------------------------------- > > (Updated March 29, 2016, 12:19 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-4950 > https://issues.apache.org/jira/browse/MESOS-4950 > > > Repository: mesos > > > Description > ------- > > Trivial change to add a comment to invoke `send` only after > receiving the `connected` callback. If not, all calls would > be dropped while disconnected. > > > Diffs > ----- > > include/mesos/v1/scheduler.hpp 765935e97b6c1686ab464a5cf1cf2dfd816f51f1 > > Diff: https://reviews.apache.org/r/45410/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >