-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44361/
-----------------------------------------------------------

(Updated March 29, 2016, 11:08 p.m.)


Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya.


Changes
-------

Addressed bmahler's comments. I also updated the test description to reflect 
tests for passing relative paths to --with-nvml-include and --with-nvml-lib.


Bugs: MESOS-4861
    https://issues.apache.org/jira/browse/MESOS-4861


Repository: mesos


Description
-------

This is the initial commit to begin adding native support for GPUs in
Mesos. This initial version will only include support for Nvidia GPUs
that can be managed by the Nvidia Management Library (nvml).

The configure flags added in this commit can be used to enable Nvidia
GPU support, as well as specify the installation directories of the
nvml header and library files if not already installed in standard
include/library paths on the system.

In a subsequent commit, we will use these configure flags to
conditionally build support for Nvidia GPUs into Mesos.


Diffs (updated)
-----

  configure.ac 9ec4bc1cff3b0b46dd2e7ece2c1fbbbb2d19ffb8 

Diff: https://reviews.apache.org/r/44361/diff/


Testing (updated)
-------

I ran `bootstrap` to generate configure.

I then ran:

```
mkdir build; cd build
../configure --enable-nvidia-gpu-support
../configure --enable-nvidia-gpu-support 
--with-nvml-include=<relative_path_to_headers>
../configure --enable-nvidia-gpu-support --with-nvml-include=<path_to_headers>
../configure --enable-nvidia-gpu-support --with-nvml-include=<bogus_path>
../configure --enable-nvidia-gpu-support 
--with-nvml-include=<relative_path_to_lib>
../configure --enable-nvidia-gpu-support --with-nvml-lib=<path_to_lib>
../configure --enable-nvidia-gpu-support --with-nvml-lib=<bogus_path>
../configure --enable-nvidia-gpu-support --with-nvml-include=<bogus_path> 
--with-nvml-lib=<path_to_lib>
../configure --enable-nvidia-gpu-support --with-nvml-include=<path_to_headers> 
--with-nvml-lib=<bogus_path>
../configure --enable-nvidia-gpu-support --with-nvml-include=<bogus_path> 
--with-nvml-lib=<bogus_path>
../configure --enable-nvidia-gpu-support --with-nvml-include=<path_to_headers> 
--with-nvml-lib=<path_to_lib>
```

And verified the proper errors / successes in each case (only the last one is a 
success).

The exact command I ran in the success case for my configuration was:
```
../configure --enable-nvidia-gpu-support 
--with-nvml-include=/opt/nvidia-gdk/usr/include 
--with-nvml-lib=/opt/nvidia-gdk/usr/src/gdk/nvml/lib
```


Thanks,

Kevin Klues

Reply via email to