> On March 18, 2016, 5:34 a.m., Guangya Liu wrote: > > src/cli/execute.cpp, line 456 > > <https://reviews.apache.org/r/45008/diff/1/?file=1304823#file1304823line456> > > > > Can you please add some comments here for why `devolve`here? > > > > Do we have plan to update all `status` use V1?
I think Anand did it because mesos::internal::protobuf::isTerminalState() takes a v0 state. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45008/#review124147 ----------------------------------------------------------- On March 28, 2016, 10:32 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45008/ > ----------------------------------------------------------- > > (Updated March 28, 2016, 10:32 p.m.) > > > Review request for mesos, Guangya Liu and Vinod Kone. > > > Bugs: MESOS-3559 > https://issues.apache.org/jira/browse/MESOS-3559 > > > Repository: mesos > > > Description > ------- > > This change moves the command scheduler (`mesos-execute`) to use > the scheduler library instead of the driver. > > > Diffs > ----- > > src/cli/execute.cpp ed42cb568f3d16856f48b3bbd354cb2b0fb83e8e > > Diff: https://reviews.apache.org/r/45008/diff/ > > > Testing > ------- > > make check, an example run: > > ``` > build git:(mesos-3559) : ./src/mesos-execute --command="sleep 1" > --master=127.0.1.1:5050 --name=task1 > I0317 19:04:43.974733 21678 scheduler.cpp:172] Version: 0.29.0 > Subscribed with ID '7decbfe9-8b46-48f5-8573-0a5a3e465a1f-0001 > task task1 submitted to agent 5a54dc00-7fd8-477f-a666-1b1ab86a0033-S0 > Received status update TASK_RUNNING for task task1 > Received status update TASK_FINISHED for task task1 > E0317 19:04:45.148203 21680 scheduler.cpp:585] End-Of-File received from > master. The master closed the event stream > > build git:(mesos-3559) : echo $? > 0 > ``` > > > Thanks, > > Anand Mazumdar > >
