----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45408/#review125981 -----------------------------------------------------------
include/mesos/v1/scheduler.hpp (line 50) <https://reviews.apache.org/r/45408/#comment188902> s/events/calls and events/ ? include/mesos/v1/scheduler.hpp (lines 70 - 73) <https://reviews.apache.org/r/45408/#comment188903> Can you add more meat to this comment? For example, error event is not sent if the master is disconnected but the call is silently dropped. Also mention that clients should send() a call only after they have received a connected() callback and that they shouldn't send a call if they received a disconnected() callback until they get a connected() callback again. You can put some of this comment above the Mesos constructor. include/mesos/v1/scheduler.hpp (line 85) <https://reviews.apache.org/r/45408/#comment188904> Also mention that clients will get a disconnected() and connected() callback after making this call? - Vinod Kone On March 29, 2016, 12:18 a.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45408/ > ----------------------------------------------------------- > > (Updated March 29, 2016, 12:18 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-4950 > https://issues.apache.org/jira/browse/MESOS-4950 > > > Repository: mesos > > > Description > ------- > > This change adds a `reconnect` method that allows schedulers > to force a reconnection with the master. This is useful when > the scheduler detects that there is a one-way partition with > the master (e.g., lack of `HEARTBEAT` events) and wants to > trigger a reconnection rather than relying on the `disconnected` > callback. > > > Diffs > ----- > > include/mesos/v1/scheduler.hpp 765935e97b6c1686ab464a5cf1cf2dfd816f51f1 > src/scheduler/scheduler.cpp 13972449363b633f21ddec7649b1b170703c773a > > Diff: https://reviews.apache.org/r/45408/diff/ > > > Testing > ------- > > make check (added a test later in the review chain) > > > Thanks, > > Anand Mazumdar > >
